E2E Tests: Reduce default timeout #10863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
requested changes
Apr 23, 2024
nwmac
force-pushed
the
e2e-timeout
branch
2 times, most recently
from
018f175 to
9f3762a
Compare
|
@richard-cox @aalves08 This one finally passed the gates - would be good to get this in |
richard-cox
approved these changes
Jun 12, 2024
| @@ -9,6 +9,9 @@ import { ChartsPage } from '@/cypress/e2e/po/pages/explorer/charts/charts.po'; | |||
| import { InstallChartPage } from '@/cypress/e2e/po/pages/explorer/charts/install-charts.po'; | |||
| import { PrometheusTab } from '@/cypress/e2e/po/pages/explorer/charts/tabs/prometheus-tab.po'; | |||
| import { GrafanaTab } from '@/cypress/e2e/po/pages/explorer/charts/tabs/grafana-tab.po'; | |||
| import { AlertingTab } from '@/cypress/e2e/po/pages/explorer/charts/tabs/alerting-tab.po'; | |||
| import { IstioTab } from '@/cypress/e2e/po/pages/explorer/charts/tabs/istio-tab.po'; | |||
| import { LONG_TIMEOUT_OPT } from '~/cypress/support/utils/timeouts'; | |||
There was a problem hiding this comment.
if there's another pr change, this could be updated to @/
| @@ -44,11 +44,20 @@ describe('Charts', { tags: ['@charts', '@adminUser'] }, () => { | |||
|
|
|||
| installPage.waitForPage('repo-type=cluster&repo=rancher-charts&chart=rancher-backup'); | |||
|
|
|||
| // Scroll into view - scroll to bottom of view | |||
| cy.get('.main-layout > .outlet > .outer-container').scrollTo('bottom'); | |||
There was a problem hiding this comment.
Optional, should this go on the PagePo as a helper?
nwmac
added a commit
to nwmac/dashboard
that referenced
this pull request
Oct 24, 2024
* e2e tests: reducedefault timeout to 10s * Use timeouts in cluster manager test * Fix timeout for cluster deletion * Try even shorter timeout * Revert back to 10s * Address PR feedback * Use common type for options * Fix lint * Fix lint - too many blank lines * Increase timeout for terminal * Improve reliability of the Istio tests * Fix lint issues * Fix typos in refactor to PO * Fix typo in tab name * Add resilience for the docs test * Add timeout for extensions test * Add test resilience for docs page * Fix lint by removing trailing spaces * Add test resilience * Fix link opening exception handling * Fix merge issue * Fix whitespace * Fix indentation * Update extensions.spec.ts * Fix lint and use standard timeout option * Fix merge issue and revert some extra changes * Revert extra test changes * Remove test change for extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8956
This PR reduces the default cypress timeout used in e2e tests from 60s to 10s.
There are a few tests that need updating to specifically used a longer timeout - a set of timeouts has been created in a utility file and used in the appropriate places.
When a test fails, the test is retried 3 times - so before this PR, a test failure would add 3 minutes to the test run - with this PR it adds 30 seconds.
We can look to reduce the timeout further, but more tests will need to be checked and updated.
This PR also updates a couple of tests to make them more resilient:
Also added tag for
emberand applied to relevant tests.